Reviewing in progress work on Github

Andrew Wilkins andrew.wilkins at canonical.com
Thu Jun 5 09:03:50 UTC 2014


On Thu, Jun 5, 2014 at 4:43 PM, Dimiter Naydenov <
dimiter.naydenov at canonical.com> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> I spent some time yesterday researching various ways to be productive
> with git and GitHub. What you're talking about reminded me of this:
> https://github.com/github/hub
>
> It's a CLI for git that allows you to create pull requests on GitHub
> and lots more. In addition, you can do a feature branch and then run
> $ git compare master..feature
>
> This will bring up a browser with a permalink to a GitHub compare
> page, where you can solicit comments about a work in progress, and
> later convert it to a pull request.
>
> Check it out, might be just what we need.


This tool looks very useful, thanks Dimiter.
I don't see a way to create comments on a comparison page, though. Am I
missing something?


> On  5.06.2014 06:25, Ian Booth wrote:
> > One of the many things I miss now that we have moved to Github/git
> > is the ability to put up a merge proposal with in-progress work,
> > allowing collaboration on the implementation as it evolves etc.
> > Launchpad supported this nicely, as it didn't spam people with
> > emails for wip mps etc.
> >
> > I don't think Github supports this concept. Perhaps a way around it
> > is to do a pull request against one's forked copy of the main Juju
> > repo. That way, people can still easily see your work, but without
> > the general spam. Sadly, it doesn't allow the pull request to then
> > be re-targetted to the Juju repo when ready to be reviewed for
> > real. Or does it?
> >
> > Does anyone have any better ideas how to do this?
> >
>
>
> - --
> Dimiter Naydenov <dimiter.naydenov at canonical.com>
> juju-core team
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQEcBAEBAgAGBQJTkC2hAAoJENzxV2TbLzHwfM8IAKgzgNA8JcMNOZE4MzEe+4d9
> k49ubzUL1GvAQ7iKS1svchWfGcbM6jCmxxHtTFEmoSj5mFSGQx05fDtbg5wSTc9d
> +8A8YqpLQXrxOQJHqwgMWTzB/XGt0E4GJI+YtKhM5MJukwgQ38ul/UDLs4UGs7AR
> htAeRqHFAx1EkdxKgTa+HM6/cn5rAcdRtc4rHUG1iqzsaAlm7/RLnWOJOk7EDKc/
> 8cJgc7vQ97P20vvZAjYaMxEBPQDCYDiMDnhXQnpPmFS9rQdSoggW67nuUf9UfO/w
> yfckST0cPpzPfOdzOQtK7pF04kwRHISEVleQxZV7PffDU2Rpm6AFH0gExWpEa7Q=
> =GKGz
> -----END PGP SIGNATURE-----
>
> --
> Juju-dev mailing list
> Juju-dev at lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140605/cd1964a4/attachment.html>


More information about the Juju-dev mailing list