Reviewing in progress work on Github

[Dimiter Naydenov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Right, my bad - so it's just a diff of the branch changes, and it can
be converted to a PR using the green button at the top, so you can add
comments. I guess for such cases we can use it and tag the PR as WIP
somehow (i.e. in the title or description). Once it's good to land,
edit that tag out and proceed, or if it's rejected, just delete the PR.

On  5.06.2014 12:03, Andrew Wilkins wrote:
> On Thu, Jun 5, 2014 at 4:43 PM, Dimiter Naydenov 
> <dimiter.naydenov at canonical.com
> <mailto:dimiter.naydenov at canonical.com>> wrote:
> 
> I spent some time yesterday researching various ways to be
> productive with git and GitHub. What you're talking about reminded
> me of this: https://github.com/github/hub
> 
> It's a CLI for git that allows you to create pull requests on
> GitHub and lots more. In addition, you can do a feature branch and
> then run $ git compare master..feature
> 
> This will bring up a browser with a permalink to a GitHub compare 
> page, where you can solicit comments about a work in progress, and 
> later convert it to a pull request.
> 
> Check it out, might be just what we need.
> 
> 
>> This tool looks very useful, thanks Dimiter. I don't see a way to
>> create comments on a comparison page, though. Am I missing
>> something?
> 
> 
> On  5.06.2014 06:25, Ian Booth wrote:
>> One of the many things I miss now that we have moved to
>> Github/git is the ability to put up a merge proposal with
>> in-progress work, allowing collaboration on the implementation as
>> it evolves etc. Launchpad supported this nicely, as it didn't
>> spam people with emails for wip mps etc.
> 
>> I don't think Github supports this concept. Perhaps a way around
>> it is to do a pull request against one's forked copy of the main
>> Juju repo. That way, people can still easily see your work, but
>> without the general spam. Sadly, it doesn't allow the pull
>> request to then be re-targetted to the Juju repo when ready to be
>> reviewed for real. Or does it?
> 
>> Does anyone have any better ideas how to do this?
> 
> 
> 
> 
> -- Juju-dev mailing list Juju-dev at lists.ubuntu.com
> <mailto:Juju-dev at lists.ubuntu.com> Modify settings or unsubscribe
> at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
> 
> 

- -- 
Dimiter Naydenov <dimiter.naydenov at canonical.com>
juju-core team
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTkDdXAAoJENzxV2TbLzHwouIH/1qbXeicfJxx8UUZp2rrWxOA
I9jUbOMufoCJtY3O9FvLhGRVfqko1IRaMvmGLqI3MaCFDi/Lspdytdpq9GQ9Qiu9
aHjr0r3jlnHNNPmuYJSnx7vl7i8YM6LD/vcY9ubauGAYEczrCiV7axl67oUHB2CO
IrHSn51Prz90XpRaOcOL8+CQd+wg1Suqd1JFuXcys5WPv49WH+DVv//X9RZnl7Kc
mqA17E+uxIGz6aG+8NRP9GOBi/CJCsh6kCquh9MmI22teH+EZB3kZ1MMbI8hTpdm
klD7WrMpNb3PjHGBwIEJDLE1oamD5oE1k8ETjwutr/PxWAATc6vsQktB5AZeC5M=
=+oAW
-----END PGP SIGNATURE-----