ACK: [PATCH] acpi: wmi: remove redundant initialization of 'info'

ivanhu ivan.hu at canonical.com
Tue Feb 6 03:01:36 UTC 2018



On 01/31/2018 06:10 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Pointer info is being assigned twice, once at initialization and
> again in a for-loop. Remove the redundant first initialization.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/acpi/wmi/wmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/wmi/wmi.c b/src/acpi/wmi/wmi.c
> index 7d8f36ea..1bdd7975 100644
> --- a/src/acpi/wmi/wmi.c
> +++ b/src/acpi/wmi/wmi.c
> @@ -143,7 +143,7 @@ static int wmi_deinit(fwts_framework *fw)
>   */
>  static fwts_wmi_known_guid *wmi_find_guid(char *guid)
>  {
> -	fwts_wmi_known_guid *info = fwts_wmi_known_guids;
> +	fwts_wmi_known_guid *info;
>  
>  	for (info = fwts_wmi_known_guids; info->guid != NULL; info++)
>  		if (strcmp(info->guid, guid) == 0)

Acked-by: Ivan Hu <ivan.hu at canonical.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180206/95c86a76/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180206/95c86a76/attachment.sig>


More information about the fwts-devel mailing list