ACK: [PATCH] acpi: wmi: remove redundant initialization of 'info'

Alex Hung alex.hung at canonical.com
Fri Feb 2 02:48:35 UTC 2018


On 2018-01-31 02:10 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Pointer info is being assigned twice, once at initialization and
> again in a for-loop. Remove the redundant first initialization.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/acpi/wmi/wmi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/acpi/wmi/wmi.c b/src/acpi/wmi/wmi.c
> index 7d8f36ea..1bdd7975 100644
> --- a/src/acpi/wmi/wmi.c
> +++ b/src/acpi/wmi/wmi.c
> @@ -143,7 +143,7 @@ static int wmi_deinit(fwts_framework *fw)
>    */
>   static fwts_wmi_known_guid *wmi_find_guid(char *guid)
>   {
> -	fwts_wmi_known_guid *info = fwts_wmi_known_guids;
> +	fwts_wmi_known_guid *info;
>   
>   	for (info = fwts_wmi_known_guids; info->guid != NULL; info++)
>   		if (strcmp(info->guid, guid) == 0)
> 

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list