[PATCH] Introduce IPMI BMC Info

[Jeremy Kerr]

Hi Deb,

>         FWTS_ASSERT((n * (sizeof(feature_names[0].name) - 1)) +
>                                 ((n-1) * (sizeof(sep) - 1)) + 1 <
>                         sizeof(str), str_too_small);
> 
> size of feature_names[0].name is 16.

Ah, of course - we're using the maximum name length here. All good :)

> Moved the ROOT_PRIV check first to bail if ROOT_PRIV's are
> required first, so that seems most likely the overall usage flows.
> This was changed for IPMI cases since we needed ROOT_PRIV to do the
> access check for R_OK | W_OK to successfully function, but
> as you point out other users for IPMI may be able to W_OK, so we
> can add access check for W_OK in IPMI BMC Info check.

OK, as long as FWTS reports IPMI capability (ie, we check with just
R_OK), regardless of whether we have privileges to use the ipmiX device.

Cheers,


Jeremy