ACK: [PATCH] ACPI: MADT: update GICC flag checks for ACPI 6.0

[Al Stone]

On 11/04/2015 07:27 PM, ivanhu wrote:
> 
> 
> On 2015年10月31日 06:31, Al Stone wrote:
>> In the ACPI 6.0 spec, the flags field of the MADT GICC subtable uses
>> three bits, not two.  Correct the flag mask to do the test properly.
>>
>> Signed-off-by: Al Stone <al.stone at linaro.org>
>> ---
>>   src/acpi/madt/madt.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/acpi/madt/madt.c b/src/acpi/madt/madt.c
>> index f776745..1f19848 100644
>> --- a/src/acpi/madt/madt.c
>> +++ b/src/acpi/madt/madt.c
>> @@ -226,7 +226,7 @@ static int madt_test1(fwts_framework *fw)
>>                           "MADT GIC C Structure reserved field should be zero, "
>>                           "instead got 0x%" PRIx32 ".", gic->reserved);
>>                   }
>> -                if (gic->flags & 0xfffffffc) {
>> +                if (gic->flags & 0xfffffff8) {
>>                       passed = false;
>>                       fwts_failed(fw, LOG_LEVEL_MEDIUM,
>>                           "MADTGICFLags",
>>
> 
> Acked-by: Ivan Hu <ivan.hu at canonical.com>
> 

It just occurred to me that the fwts_failed() call in this patch may also
need a fix to use the new mask, too...I'll try to check on it soon and see.

-- 
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone at linaro.org
-----------------------------------