ACK: [PATCH] MADT subtables: Local SAPIC structure has 3 reserved bytes, not 1

Alex Hung alex.hung at canonical.com
Mon Nov 2 02:19:01 UTC 2015


On 10/30/2015 04:39 AM, Al Stone wrote:
> According to section 5.2.12.10 of the ACPI 6.0 spec, the reserved field
> starts at byte offset 5 and is 3 bytes long.  However, the subtable data
> structure being used makes it only 1 byte long.  This is incorrect, so
> fix it.
> 
> Signed-off-by: Al Stone <al.stone at linaro.org>
> ---
>  src/lib/include/fwts_acpi.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lib/include/fwts_acpi.h b/src/lib/include/fwts_acpi.h
> index 5cc4cb4..cf8f4b8 100644
> --- a/src/lib/include/fwts_acpi.h
> +++ b/src/lib/include/fwts_acpi.h
> @@ -473,7 +473,7 @@ typedef struct {
>  	uint8_t		acpi_processor_id;
>  	uint8_t		local_sapic_id;
>  	uint8_t		local_sapic_eid;
> -	uint8_t		reserved;
> +	uint8_t		reserved[3];
>  	uint32_t	flags;
>  	uint32_t	uid_value;
>  	char		uid_string[0];
> 

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list