[PATCH v2 0/2] Miscellaneous updates

Ricardo Neri ricardo.neri-calderon at linux.intel.com
Wed Feb 11 20:43:11 UTC 2015


Hi!

This is v2 of my submission for updates to FWTS related on how efi_runtime 
accesses user space memory and handling UEFI variable names. This is an
incremental submission. The first submission can be found here:

https://lists.ubuntu.com/archives/fwts-devel/2015-February/005858.html

This incremental patchset looks different because:
1) It contains only the patches that have not been acked by Colin.
2) Contains an extra patch to fixes in the error path efi_runtime_set_variable
   that was not included in the first submission.

Patch 1 is in fact v2 of patch 5 in my first submission (see here:
https://lists.ubuntu.com/archives/fwts-devel/2015-February/005860.html). Patch
2 is a new patch.

Changes since v1:

* Handle error in realloc when growing the size of the buffer for the variable
  name.
* Since failed reallocs are not firmware errors, we return FWTS_SKIP. This
  required reworking the error paths in the involved functions
* Correct potential memory leak and dereference of NULL pointer in 
  efi_runtime_set_variable.
  
Changes apply cleanly on top of my first submission (minus patch 5). However,
if resubmitting the complete series is more appropriate, please let me know
and I will gladly do it.


Ricardo Neri (2):
  uefirtvariable: allow large sizes for variable names
  efi_runtime: handle memory errors when setting variables

 efi_runtime/efi_runtime.c                |   8 +-
 src/uefi/uefirtvariable/uefirtvariable.c | 152 ++++++++++++++++++++++++++-----
 2 files changed, 133 insertions(+), 27 deletions(-)

-- 
1.9.1




More information about the fwts-devel mailing list