[PATCH] dmicheck: fix the range of Interface Type on Type38 (LP: #1416092)

Keng-Yu Lin keng-yu.lin at canonical.com
Mon Feb 9 06:23:19 UTC 2015


On Fri, Jan 30, 2015 at 4:32 AM, Ivan Hu <ivan.hu at canonical.com> wrote:
> The SMBIOS spec 7.39.1 define the IPMI Device Information: BMC Interface Type
> Field 04h to 0FFh as reserved for future assignment by this specification, the
> maximum value should be 03h.
>
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 3d7cd24..f2d63e5 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1392,7 +1392,7 @@ static void dmicheck_entry(fwts_framework *fw,
>
>                 case 38: /* 7.39 */
>                         table = "IPMI Device Information (Type 38)";
> -                       dmi_min_max_uint8_check(fw, table, addr, "Interface Type", hdr, 0x4, 0x0, 0x4);
> +                       dmi_min_max_uint8_check(fw, table, addr, "Interface Type", hdr, 0x4, 0x0, 0x3);
>                         break;
>
>                 case 39: /* 7.40 */
> --
> 1.9.1
>
>

Acked-by: Keng-Yu Lin <kengyu at canonical.com>



More information about the fwts-devel mailing list