ACK: [PATCH 02/10] acpi: crsdump: fix shadowing of variable 'sharing'

IvanHu ivan.hu at canonical.com
Mon Jul 14 07:14:44 UTC 2014


On 06/13/2014 02:03 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> variable sharing was being shadowed, so rename the inner scoped
> one to int_sharing just to avoid any confusion
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/acpi/crsdump/crsdump.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/acpi/crsdump/crsdump.c b/src/acpi/crsdump/crsdump.c
> index 982b97b..590ae52 100644
> --- a/src/acpi/crsdump/crsdump.c
> +++ b/src/acpi/crsdump/crsdump.c
> @@ -787,7 +787,7 @@ static void crsdump_large_resource_items(
>   				crsdump_show(fw, objname, "GPIO Connection Descriptor",
>   					data, crs_length, header, info);
>   			} else if (data[4] == 1) {
> -				static const char *sharing[] = {
> +				static const char *int_sharing[] = {
>   					"Exclusive",
>   					"Shared",
>   				};
> @@ -807,7 +807,7 @@ static void crsdump_large_resource_items(
>   					CRS_BITX("Consumer/Producer",		5, 1, consumer),
>   					CRS_UINT("Reserved",			6, 8),
>   					CRS_BITS("Reserved",			7, 128 | 64 | 32 | 16),
> -					CRS_BITX("Interrupt Sharing",		7, 8, sharing),
> +					CRS_BITX("Interrupt Sharing",		7, 8, int_sharing),
>   					CRS_BITS("Reserved",			7, 4),
>   					CRS_BITX("I/O Restriction",		7, 2 | 1, restriction),
>   					CRS_UINT("Interrupt and I/O Flags",	8, 8),
>


Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list