ACK: [PATCH 03/10] acpi: method: fix shadowing of variable 'obj'

Alex Hung alex.hung at canonical.com
Fri Jul 11 07:45:46 UTC 2014


On 06/13/2014 02:03 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> variable 'obj' was being shadowed, so rename the inner scoped
> one to objtmp just to avoid any confusion
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/acpi/method/method.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 9b789cf..1de08ec 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -670,8 +670,8 @@ static void method_test_NULL_return(
>   	 */
>   	if (fw->acpica_mode & FWTS_ACPICA_MODE_SLACK) {
>   		if ((buf != NULL) && (buf->Pointer != NULL)) {
> -			ACPI_OBJECT *obj = buf->Pointer;
> -			if (obj->Type == ACPI_TYPE_INTEGER) {
> +			ACPI_OBJECT *objtmp = buf->Pointer;
> +			if (objtmp->Type == ACPI_TYPE_INTEGER) {
>   				fwts_passed(fw, "%s returned an ACPI_TYPE_INTEGER as expected in slack mode.",
>   					name);
>   				return;
>

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list