[PATCH 1/1] cpu: msr: disabled test for non-Intel/AMD architectures

[Colin Ian King]

On 09/12/11 04:22, Jeremy Kerr wrote:
> Hi Colin,
>
>> From: Colin Ian King<colin.king at canonical.com>
>>
>> Signed-off-by: Colin Ian King<colin.king at canonical.com>
> For single-patch series, it's probably better just to include the
> changelog in this patch, rather than as the series header. Makes it
> easier for the committer to just git-am the patch.
OK, I was just following the kernel-team protocol, and they seemed happy 
with that methodology. Will do next time.
>
>> --- a/src/cpu/msr/msr.c
>> +++ b/src/cpu/msr/msr.c
>> @@ -19,6 +19,8 @@
>>
>>   #include "fwts.h"
>>
>> +#ifdef FWTS_ARCH_INTEL
>> +
>>   typedef void (*msr_callback_check)(fwts_framework *fw, uint64_t val);
>>
>>   static int ncpus;
> This is going to result in an #ifdef mess; maybe we need
> msr-${FWTS_ARCH}.c instead?
Ultimately, I agree, but this should be looked at on a different spin.  
I really can't care about how this is done, non-Intel architectures are 
something that I wasn't considering when I first wrote fwts and most of 
the tests are x86 specific, so just getting the critter to build on 
non-ARM was a hack, which I agree needs fixing it a more elegant way, 
but not by me, I can't devote the cycles at the moment to this.
> Cheers,
>
>
> Jeremy