[PATCH 1/1] cpu: msr: disabled test for non-Intel/AMD architectures

Jeremy Kerr jeremy.kerr at canonical.com
Fri Dec 9 04:22:51 UTC 2011


Hi Colin,

> From: Colin Ian King <colin.king at canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>

For single-patch series, it's probably better just to include the
changelog in this patch, rather than as the series header. Makes it
easier for the committer to just git-am the patch.

> --- a/src/cpu/msr/msr.c
> +++ b/src/cpu/msr/msr.c
> @@ -19,6 +19,8 @@
>
>  #include "fwts.h"
>
> +#ifdef FWTS_ARCH_INTEL
> +
>  typedef void (*msr_callback_check)(fwts_framework *fw, uint64_t val);
>
>  static int ncpus;

This is going to result in an #ifdef mess; maybe we need
msr-${FWTS_ARCH}.c instead?

Cheers,


Jeremy




More information about the fwts-devel mailing list