[Bug 1780767] Re: Some tests are flaky due to timeout

[Benjamin Drung]

The proper fix of the flaky tests were implemented in commit
accf9969479fd39f28dc23dd1e6ec2aa06cc4303 ("tests: Fix GTK UI race
condition and reduce timeout again") which is part of apport 2.21.0.
Therefore the fix is in Ubuntu 22.10 (kinetic).

** Description changed:

+ [Impact]
+ 
  The autopkgtests are sometimes passing, sometimes stuck for more than 2h:
  http://autopkgtest.ubuntu.com/packages/apport/cosmic/amd64.
  It's blocking randomly on different tests.
  
  All tests that are stucked, implements closing a request via a timeout
  (and then, executing "run"). The bet is that the timeout is short enough
  (1s) so that, when autopkgtests infra is busy, time to execute the bash
  subcommand is taking more than a second, and so "dismissing" is ran
  before execution happens and the whole testsuite hangs.
  
  There are few instances of setting this timeout function:
  $ grep eout_add_sec test/*
  test/test_ui_gtk.py:        GLib.timeout_add_seconds(1, cont)
  test/test_ui_gtk.py:        GLib.timeout_add_seconds(1, cont)
  test/test_ui_gtk.py:        GLib.timeout_add_seconds(1, cont)
  test/test_ui_gtk.py:        GLib.timeout_add_seconds(1, c)
  test/test_ui_gtk.py:        GLib.timeout_add_seconds(1, c)
  
  Short term solution could be to increase the timeout. Long term would be
  to eliminate this potential race implementing cancelling differently.
+ The short term workaround to increase the timeout increases the test
+ execution time by five minutes.
+ 
+ [Test Plan]
+ 
+ Check that the autopkgtest succeed all architectures (except for i386).
+ 
+ [Where problems could occur]
+ 
+ The test cases are only part of the apport source package and are not
+ copied in any binary packages. Changes to the test will only affect the
+ package build and test execution.

** Summary changed:

- Some tests are flaky due to timeout
+ Some GTK UI tests are flaky due to timeout

** Also affects: apport
   Importance: Undecided
       Status: New

** Changed in: apport
       Status: New => Fix Released

** Changed in: apport
   Importance: Undecided => Low

** Changed in: apport
    Milestone: None => 2.21.0

** Description changed:

  [Impact]
  
  The autopkgtests are sometimes passing, sometimes stuck for more than 2h:
  http://autopkgtest.ubuntu.com/packages/apport/cosmic/amd64.
  It's blocking randomly on different tests.
  
  All tests that are stucked, implements closing a request via a timeout
  (and then, executing "run"). The bet is that the timeout is short enough
  (1s) so that, when autopkgtests infra is busy, time to execute the bash
  subcommand is taking more than a second, and so "dismissing" is ran
  before execution happens and the whole testsuite hangs.
  
  There are few instances of setting this timeout function:
  $ grep eout_add_sec test/*
  test/test_ui_gtk.py:        GLib.timeout_add_seconds(1, cont)
  test/test_ui_gtk.py:        GLib.timeout_add_seconds(1, cont)
  test/test_ui_gtk.py:        GLib.timeout_add_seconds(1, cont)
  test/test_ui_gtk.py:        GLib.timeout_add_seconds(1, c)
  test/test_ui_gtk.py:        GLib.timeout_add_seconds(1, c)
  
  Short term solution could be to increase the timeout. Long term would be
  to eliminate this potential race implementing cancelling differently.
  The short term workaround to increase the timeout increases the test
  execution time by five minutes.
  
  [Test Plan]
  
- Check that the autopkgtest succeed all architectures (except for i386).
+ Check that the autopkgtest succeed on all architectures (except for
+ i386).
  
  [Where problems could occur]
  
  The test cases are only part of the apport source package and are not
  copied in any binary packages. Changes to the test will only affect the
  package build and test execution.

** Also affects: apport (Ubuntu Focal)
   Importance: Undecided
       Status: New

** Also affects: apport (Ubuntu Jammy)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apport in Ubuntu.
https://bugs.launchpad.net/bugs/1780767

Title:
  Some GTK UI tests are flaky due to timeout

Status in Apport:
  Fix Released
Status in apport package in Ubuntu:
  Fix Released
Status in apport source package in Bionic:
  Fix Released
Status in apport source package in Focal:
  New
Status in apport source package in Jammy:
  New

Bug description:
  [Impact]

  The autopkgtests are sometimes passing, sometimes stuck for more than 2h:
  http://autopkgtest.ubuntu.com/packages/apport/cosmic/amd64.
  It's blocking randomly on different tests.

  All tests that are stucked, implements closing a request via a timeout
  (and then, executing "run"). The bet is that the timeout is short
  enough (1s) so that, when autopkgtests infra is busy, time to execute
  the bash subcommand is taking more than a second, and so "dismissing"
  is ran before execution happens and the whole testsuite hangs.

  There are few instances of setting this timeout function:
  $ grep eout_add_sec test/*
  test/test_ui_gtk.py:        GLib.timeout_add_seconds(1, cont)
  test/test_ui_gtk.py:        GLib.timeout_add_seconds(1, cont)
  test/test_ui_gtk.py:        GLib.timeout_add_seconds(1, cont)
  test/test_ui_gtk.py:        GLib.timeout_add_seconds(1, c)
  test/test_ui_gtk.py:        GLib.timeout_add_seconds(1, c)

  Short term solution could be to increase the timeout. Long term would
  be to eliminate this potential race implementing cancelling
  differently. The short term workaround to increase the timeout
  increases the test execution time by five minutes.

  [Test Plan]

  Check that the autopkgtest succeed on all architectures (except for
  i386).

  [Where problems could occur]

  The test cases are only part of the apport source package and are not
  copied in any binary packages. Changes to the test will only affect
  the package build and test execution.

To manage notifications about this bug go to:
https://bugs.launchpad.net/apport/+bug/1780767/+subscriptions