[Bug 1973785] Re: lock screen message appeared during an SSH upgrade

[Nick Rosbrook]

I have tested upgrade from Impish to Jammy with package version
1:22.04.11 using the test plan above (and appending --proposed to do-
release-upgrade), and I have verified this issue is fixed.

** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1973785

Title:
  lock screen message appeared during an SSH upgrade

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Jammy:
  Fix Committed

Bug description:
  [Impact]

  Server users will see an unnecessary error message about failing to
  disable the lock screen, which may cause confusion.

  [Test Plan]

  * Obtain a console on Impish server, e.g. ssh to a remote host.
  * Verify that XDG_SESSION_TYPE is set to 'tty':
    
    $ echo $XDG_SESSION_TYPE

  * Start a release upgrade:

    $ do-release-upgrade

  * After accepting the prompt to start the upgrade, observe the "Unable
  to disable lock screen" message.

  [Where problems could occur]

  The patch changes the early-return condition in the except block in
  _inhibitIdle. If problems occurred, it would be related to the "Unable
  to disable lock screen" message.

  [Original Description]

  I was upgrading and Ubuntu 20.04 system to Ubuntu 22.04 over an ssh
  connection and noticed the following message:

  `Unable to disable lock screen

  It is highly recommended that the lock screen be disabled during the
  upgrade to prevent later issues. Please ensure your screen lock is
  disabled before continuing.

  To continue please press [ENTER]`

  Given that I'm connected via ssh the message seems unnecessary. Some
  details from main.log:

  bdmurray at clean-focal-amd64:~$ head /var/log/dist-upgrade/main.log
  2022-05-17 07:59:05,380 INFO Using config files '['./DistUpgrade.cfg.focal', '/etc/update-manager/release-upgrades.d/ubuntu-advantage-upgrades.cfg']'
  2022-05-17 07:59:05,381 INFO uname information: 'Linux clean-focal-amd64 5.13.0-41-generic #46~20.04.1-Ubuntu SMP Wed Apr 20 13:16:21 UTC 2022 x86_64'
  2022-05-17 07:59:05,677 INFO apt version: '2.0.6'
  2022-05-17 07:59:05,677 INFO python version: '3.8.10 (default, Mar 15 2022, 12:22:08)
  [GCC 9.4.0]'
  2022-05-17 07:59:05,679 INFO release-upgrader version '22.04.10' started

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1973785/+subscriptions