[Bug 1785165] Re: firmware update on fwupdate version 10-3 not work on some AMI's firmwares

[Yuan-Chen Cheng]

set back to fix committed based on #24.

@Brian, please kindly review again.

** Changed in: fwupdate (Ubuntu Bionic)
       Status: Incomplete => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to fwupdate in Ubuntu.
https://bugs.launchpad.net/bugs/1785165

Title:
  firmware update on fwupdate version 10-3 not work on some AMI's
  firmwares

Status in OEM Priority Project:
  Fix Committed
Status in fwupdate package in Ubuntu:
  Fix Released
Status in fwupdate-signed package in Ubuntu:
  Fix Released
Status in fwupdate source package in Bionic:
  Fix Committed
Status in fwupdate-signed source package in Bionic:
  Fix Committed

Bug description:
  [Rationale]
  The commited patch, Handle ux capsule updates, https://github.com/rhboot/fwupdate/commit/2561423dd68622dcf8a7542709f332edb517d34e, change to calculate CapsuleBlockDesc Length = CapsuleHeader.CapsuleImageSize + HeaderSize, but on AMI BIOS image which is without capsule header. Fwudpate package on 18.04(version 10-3) included the "Handle ux capsule updates" causes those machine with AMI firmware cannot do firmware update.
  The fixed patch have been committed, https://github.com/rhboot/fwupdate/commit/863db45c246acd2cbeff0b4e32d3a8312475ff6a and fix the incorrect cbd_length.

  [Impact]
  Machines with certain AMI firmware implementations cannot do firmware update.

  [Test cases]
  1. install ubuntu 18.04 on AMI's bios machine.
  2. get the update firmware
  3. See if this machine support firmware update,
     #sudo fwudpate -s
  4. get the update GUID
     #sudo fwupdate -l
  5. do firmeare update
     #sudo -a GUID  firmware.bin
  6. reboot

  Alternate test case:
  1. Install update from LVFS with fwupd
  2. Verify update works.

  [Other info]
  This is is very intentionally not a single patch backport.  fwupdate identifies itself to fwupd by version.  fwupd uses this information to determine when to offer updates based on fwupdate behavior.
  If identified as fwupdate 10 many updates will not apply.
  If identified as fwupdate 12 but only with a backport it's an unknown behavior and not safe.

  The best thing to do is to backport fwupdate 12 fully.

  [Regression potential]
  Regressions would manifest in BIOS updates failing to apply.
  This regression risk should be low for the following reasons:
  1. This is a full backport of fwupdate 12.  It doesn't take the risk of an unexpected set of code paths that lead to different failures.
  2. fwupdate 12 has been released a long time and has been merged into fwupd 1.1.x.  It's been verified by thousands of firmware upgrades already across many OEMs.

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/1785165/+subscriptions