[Bug 1785165] Please test proposed package

[Timo Aaltonen]

Hello Ivan, or anyone else affected,

Accepted fwupdate-signed into bionic-proposed. The package will build
now and be available at https://launchpad.net/ubuntu/+source/fwupdate-
signed/1.19bionic2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-bionic to verification-done-bionic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-bionic. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to fwupdate in Ubuntu.
https://bugs.launchpad.net/bugs/1785165

Title:
  firmware update on fwupdate version 10-3 not work on some AMI's
  firmwares

Status in fwupdate package in Ubuntu:
  Fix Released
Status in fwupdate-signed package in Ubuntu:
  Fix Released
Status in fwupdate source package in Bionic:
  Fix Committed
Status in fwupdate-signed source package in Bionic:
  Fix Committed

Bug description:
  [Rationale]
  The commited patch, Handle ux capsule updates, https://github.com/rhboot/fwupdate/commit/2561423dd68622dcf8a7542709f332edb517d34e, change to calculate CapsuleBlockDesc Length = CapsuleHeader.CapsuleImageSize + HeaderSize, but on AMI BIOS image which is without capsule header. Fwudpate package on 18.04(version 10-3) included the "Handle ux capsule updates" causes those machine with AMI firmware cannot do firmware update.
  The fixed patch have been committed, https://github.com/rhboot/fwupdate/commit/863db45c246acd2cbeff0b4e32d3a8312475ff6a and fix the incorrect cbd_length.

  [Impact]
  Machines with certain AMI firmware implementations cannot do firmware update.

  [Test cases]
  1. install ubuntu 18.04 on AMI's bios machine.
  2. get the update firmware
  3. See if this machine support firmware update,
     #sudo fwudpate -s
  4. get the update GUID
     #sudo fwupdate -l
  5. do firmeare update
     #sudo -a GUID  firmware.bin
  6. reboot

  Alternate test case:
  1. Install update from LVFS with fwupd
  2. Verify update works.

  [Other info]
  This is is very intentionally not a single patch backport.  fwupdate identifies itself to fwupd by version.  fwupd uses this information to determine when to offer updates based on fwupdate behavior.
  If identified as fwupdate 10 many updates will not apply.
  If identified as fwupdate 12 but only with a backport it's an unknown behavior and not safe.

  The best thing to do is to backport fwupdate 12 fully.

  [Regression potential]
  Regressions would manifest in BIOS updates failing to apply.
  This regression risk should be low for the following reasons:
  1. This is a full backport of fwupdate 12.  It doesn't take the risk of an unexpected set of code paths that lead to different failures.
  2. fwupdate 12 has been released a long time and has been merged into fwupd 1.1.x.  It's been verified by thousands of firmware upgrades already across many OEMs.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/fwupdate/+bug/1785165/+subscriptions