[Bug 1825563] Re: automatically removed packages includes postgresql-10 which can result in cluster dropping

[Steve Langasek]

Hello Michael, or anyone else affected,

Accepted ubuntu-release-upgrader into disco-proposed. The package will
build now and be available at https://launchpad.net/ubuntu/+source
/ubuntu-release-upgrader/1:19.04.16.1 in a few hours, and then in the
-proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-disco to verification-done-disco. If it does not fix
the bug for you, please add a comment stating that, and change the tag
to verification-failed-disco. In either case, without details of your
testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: ubuntu-release-upgrader (Ubuntu Disco)
       Status: New => Fix Committed

** Tags added: verification-needed verification-needed-disco

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1825563

Title:
  automatically removed packages includes postgresql-10 which can result
  in cluster dropping

Status in ubuntu-release-upgrader package in Ubuntu:
  In Progress
Status in ubuntu-release-upgrader source package in Disco:
  Fix Committed

Bug description:
  [Impact]
  Users who choose to autoremove packages can have postgresql-10 removed which during its purge will drop the cluster and its databases.

  [Test Case]
  On a cosmic system
  1) install postgresql-10 and ubuntu-release-upgrader-core
  2) create a test database using psql - create database junk;
  3) fill that database with junk using pgbench e.g. pgbench -in -s10 junk
  4) verify you have data in /var/lib/postgresql - du -sh /var/lib/postgresql/*
  5) run do-release-upgrade
  6) choose to automatically remove packages (watch postgresql-10 get removed)
  7) observe you have no more data in /var/lib/postgresql

  With the version of the release upgrader in -proposed postgresql-10
  will not be removed, postgresql-11 will not be installed and you'll
  still have your data.

  [Regression Potential]
  The regex could be too generic and prevent some other packages from being removed so look at it closely.

  While upgrading to Ubuntu 19.04, the release upgrader removed
  postgresql-10. To make matters worse, apt/dpkg did NOT ask whether the
  databases should be kept and simply removed all of them.

  I believe this is due to removal_blacklist.cfg containing
  ^postgresql-.*[0-9]\.[0-9].*, which does not match newer releases such
  as postgresql-10 as it expects an X.Y version scheme. Something like
  ^postgresql-.*[0-9].* should probably be added in addition.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1825563/+subscriptions