[Bug 1825563] Re: automatically removed packages includes postgresql-10 which can result in cluster dropping

[Brian Murray]

** Description changed:

+ [Impact]
+ Users who choose to autoremove packages can have postgresql-10 removed which during its purge will drop the cluster and its databases.
+ 
+ [Test Case]
+ On a cosmic system
+ 1) install postgresql-10 and ubuntu-release-upgrader-core
+ 2) create a test database using psql - create database junk;
+ 3) fill that database with junk using pgbench e.g. pgbench -in -s10 junk
+ 4) verify you have data in /var/lib/postgresql - du -sh /var/lib/postgresql/*
+ 5) run do-release-upgrade
+ 6) choose to automatically remove packages (watch postgresql-10 get removed)
+ 7) observe you have no more data in /var/lib/postgresql
+ 
+ With the version of the release upgrader in -proposed postgresql-10 will
+ not be removed, postgresql-11 will not be installed and you'll still
+ have your data.
+ 
+ [Regression Potential]
+ The regex could be too generic and prevent some other packages from being removed so look at it closely.
+ 
  While upgrading to Ubuntu 19.04, the release upgrader removed
  postgresql-10. To make matters worse, apt/dpkg did NOT ask whether the
  databases should be kept and simply removed all of them.
  
  I believe this is due to removal_blacklist.cfg containing
  ^postgresql-.*[0-9]\.[0-9].*, which does not match newer releases such
  as postgresql-10 as it expects an X.Y version scheme. Something like
  ^postgresql-.*[0-9].* should probably be added in addition.

** Tags added: disco eoan

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1825563

Title:
  automatically removed packages includes postgresql-10 which can result
  in cluster dropping

Status in ubuntu-release-upgrader package in Ubuntu:
  In Progress

Bug description:
  [Impact]
  Users who choose to autoremove packages can have postgresql-10 removed which during its purge will drop the cluster and its databases.

  [Test Case]
  On a cosmic system
  1) install postgresql-10 and ubuntu-release-upgrader-core
  2) create a test database using psql - create database junk;
  3) fill that database with junk using pgbench e.g. pgbench -in -s10 junk
  4) verify you have data in /var/lib/postgresql - du -sh /var/lib/postgresql/*
  5) run do-release-upgrade
  6) choose to automatically remove packages (watch postgresql-10 get removed)
  7) observe you have no more data in /var/lib/postgresql

  With the version of the release upgrader in -proposed postgresql-10
  will not be removed, postgresql-11 will not be installed and you'll
  still have your data.

  [Regression Potential]
  The regex could be too generic and prevent some other packages from being removed so look at it closely.

  While upgrading to Ubuntu 19.04, the release upgrader removed
  postgresql-10. To make matters worse, apt/dpkg did NOT ask whether the
  databases should be kept and simply removed all of them.

  I believe this is due to removal_blacklist.cfg containing
  ^postgresql-.*[0-9]\.[0-9].*, which does not match newer releases such
  as postgresql-10 as it expects an X.Y version scheme. Something like
  ^postgresql-.*[0-9].* should probably be added in addition.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1825563/+subscriptions