[Bug 1783738] Re: _checkStoreConnectivity uses translatable strings for error checking

[Łukasz Zemczak]

Hello Jean-Baptiste, or anyone else affected,

Accepted ubuntu-release-upgrader into bionic-proposed. The package will
build now and be available at https://launchpad.net/ubuntu/+source
/ubuntu-release-upgrader/1:18.04.22 in a few hours, and then in the
-proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-bionic to verification-done-bionic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-bionic. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: ubuntu-release-upgrader (Ubuntu Bionic)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1783738

Title:
  _checkStoreConnectivity uses translatable strings for error checking

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Bionic:
  Fix Committed

Bug description:
  [Impact]
  There currently are not any translation files for snappy that I could find for Ubuntu 16.04, the release from which an upgrade would be happening, however those might be SRU'ed so its still worth fixing.

  [Test Case]
  Given that there are no translations of snappy in Ubuntu 16.04 yet we should just test that there are no regressions. This can be done by ensuring that you are running an old version of snapd which doesn't support the 'debug connectivity' command.

  [Regression Potential]
  Already addressed in the test case above.

  In DistUpgradeQuirks.py in _checkStoreConnectivity there is this code:

  451         elif 'error: unknown command' in connected[1]:
  [...]
  461         elif 'error: access denied' in connected[1]:

  These tests will fail in a non-english language. For example in
  French:

  u at vm:~$ snap debug xxx
  erreur : unknown command "debug", see 'snap help'
  u at vm:~$ snap debug connectivity
  erreur : access denied (essayez avec sudo)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1783738/+subscriptions