[Bug 1783738] Re: _checkStoreConnectivity uses translatable strings for error checking

[Brian Murray]

** Changed in: ubuntu-release-upgrader (Ubuntu Bionic)
   Importance: High => Medium

** Description changed:

+ [Impact]
+ There currently are not any translation files for snappy that I could find for Ubuntu 16.04, the release from which an upgrade would be happening, however those might be SRU'ed so its still worth fixing.
+ 
+ [Test Case]
+ Given that there are no translations of snappy in Ubuntu 16.04 yet we should just test that there are no regressions. This can be done by ensuring that you are running an old version of snapd which doesn't support the 'debug connectivity' command.
+ 
+ [Regression Potential]
+ Already addressed in the test case above.
+ 
  In DistUpgradeQuirks.py in _checkStoreConnectivity there is this code:
  
  451         elif 'error: unknown command' in connected[1]:
  [...]
  461         elif 'error: access denied' in connected[1]:
  
  These tests will fail in a non-english language. For example in French:
  
  u at vm:~$ snap debug xxx
  erreur : unknown command "debug", see 'snap help'
  u at vm:~$ snap debug connectivity
  erreur : access denied (essayez avec sudo)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1783738

Title:
  _checkStoreConnectivity uses translatable strings for error checking

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Bionic:
  In Progress

Bug description:
  [Impact]
  There currently are not any translation files for snappy that I could find for Ubuntu 16.04, the release from which an upgrade would be happening, however those might be SRU'ed so its still worth fixing.

  [Test Case]
  Given that there are no translations of snappy in Ubuntu 16.04 yet we should just test that there are no regressions. This can be done by ensuring that you are running an old version of snapd which doesn't support the 'debug connectivity' command.

  [Regression Potential]
  Already addressed in the test case above.

  In DistUpgradeQuirks.py in _checkStoreConnectivity there is this code:

  451         elif 'error: unknown command' in connected[1]:
  [...]
  461         elif 'error: access denied' in connected[1]:

  These tests will fail in a non-english language. For example in
  French:

  u at vm:~$ snap debug xxx
  erreur : unknown command "debug", see 'snap help'
  u at vm:~$ snap debug connectivity
  erreur : access denied (essayez avec sudo)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1783738/+subscriptions