[Bug 947180] [NEW] edit-patch should not unapply quilt patches

[Michael Hall]

Public bug reported:

edit-patch will currently unapply all quilt patches before committing
changes.  However, when some of those patches are applied to the branch
already, running edit-patch will unapply those as well, resulting in
more changes in the commit than the developer is actually applying.

== IRC #ubuntu-devel ==
09:50 < mhall119> so the question is, when there are applied patches on the branch, 
                  should they be unapplied in a separate revision from the actual 
                  change, or as part of the same revision
09:50 < dholbach> :)
09:50 < mhall119> not so much "if" as "when"
09:50 < cjwatson> absolutely not in a separate revision
09:50 < mhall119> cjwatson: why?
09:50 < cjwatson> because each revision should be self-contained
09:51 < cjwatson> if there are applied patches on the branch, then you should leave 
                  the branch that way
09:51 < cjwatson> if there are unapplied patches on the branch, then you should 
                  leave the branch that way
09:51 < mhall119> cjwatson: ok, but edit-patch unapplies all patches
09:51 < cjwatson> edit-patch shouldn't be changing the branch handling policy
09:51 < mhall119> so should edit-patch not be used?
09:51 < cjwatson> surely it should be fixed
09:53 < mhall119> so that's a bug in edit-patch?  If so, I'll file a bug report
09:55 < cjwatson> sounds like it; it should try as hard as possible to leave stuff 
                  the way it found it ...

** Affects: devscripts (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to devscripts in Ubuntu.
https://bugs.launchpad.net/bugs/947180

Title:
  edit-patch should not unapply quilt patches

Status in “devscripts” package in Ubuntu:
  New

Bug description:
  edit-patch will currently unapply all quilt patches before committing
  changes.  However, when some of those patches are applied to the
  branch already, running edit-patch will unapply those as well,
  resulting in more changes in the commit than the developer is actually
  applying.

  == IRC #ubuntu-devel ==
  09:50 < mhall119> so the question is, when there are applied patches on the branch, 
                    should they be unapplied in a separate revision from the actual 
                    change, or as part of the same revision
  09:50 < dholbach> :)
  09:50 < mhall119> not so much "if" as "when"
  09:50 < cjwatson> absolutely not in a separate revision
  09:50 < mhall119> cjwatson: why?
  09:50 < cjwatson> because each revision should be self-contained
  09:51 < cjwatson> if there are applied patches on the branch, then you should leave 
                    the branch that way
  09:51 < cjwatson> if there are unapplied patches on the branch, then you should 
                    leave the branch that way
  09:51 < mhall119> cjwatson: ok, but edit-patch unapplies all patches
  09:51 < cjwatson> edit-patch shouldn't be changing the branch handling policy
  09:51 < mhall119> so should edit-patch not be used?
  09:51 < cjwatson> surely it should be fixed
  09:53 < mhall119> so that's a bug in edit-patch?  If so, I'll file a bug report
  09:55 < cjwatson> sounds like it; it should try as hard as possible to leave stuff 
                    the way it found it ...

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/devscripts/+bug/947180/+subscriptions