ldm force pseudo tty allocation

[Gavin McCullagh]

Hi,

it would be nice on Edubuntu to be able to use a command like, "who" or "w"
to see who is logged in currently.  As ldm runs /etc/X11/Xsession directly
over ssh a proper login is never created and as a result, that user never
appears under these listings. 

If it's desirable (I think it is), we can add the -t option in ldm to force
pseudo-tty allocation and get thin client users to appear in the who list,
along with the ip address of the thin client which they are logged in from.

I haven't yet had time to test it but a simple patch which I think should
achieve this is:


gavinmc at edubuntu:~$ diff -u /opt/ltsp/i386/usr/sbin/ldm /tmp/ldm
--- /opt/ltsp/i386/usr/sbin/ldm 2006-05-08 18:23:44.000000000 +0100
+++ /tmp/ldm    2006-09-24 23:48:41.000000000 +0100
@@ -99,7 +99,7 @@
             os.environ['LDM_ASKPASS_FD'] = str(pipe_read)
             os.environ['SSH_ASKPASS'] = '/usr/lib/ltsp/ldm-askpass'

-            ssh_opts = ['-v',
+            ssh_opts = ['-v','-t',
                        '-X',
                         '-c', 'blowfish-cbc,aes128-cbc,3des-cbc']


Would this be likely to get accepted into ldm?  I guess there's some cost
to allocating the pseudo-tty but I would imagine it's fairly small.

Any thoughts?
Gavin