Suggested fix lp:#213718 (bazaar pager)

Richard Wilbur richard.wilbur at gmail.com
Fri Apr 10 18:56:23 UTC 2015


Daniel,

Looks like some good work you've been doing.  I'm having some trouble
with the Signal to Noise ratio--it's hard to find your code
contributions since your patch consists mostly of turning on the
execute permission bit of everything in the bzr source directory. ;>)

As that probably wasn't your intention, let's get you going with a
leaner change set.  Did you start with a branch from trunk?

bzr branch lp:bzr bzr213718

Then you shouldn't need a lot of wholesale changes to permissions, etc.

By the way, what OS are you developing under?

Next, because we've transitioned our normal process from reviewing
patches submitted on the mailing list, to pushing branches up to
launchpad, our review process is somewhat simpler.

If you have a launchpad.net account, you can proceed as outlined below
(substitute your launchpad account name for 'daniel-vedder').  If not,
you can sign up for free online at
https://www.launchpad.net
Otherwise, we'll see what we can do to accommodate your contributions.

Sincerely,
Richard


Create Launchpad Branch Recipe
=====================================

bzr branch lp:bzr bzr213718
#Nothing magic about this local branch name.
#Could use 'pager' if you prefer and substitute below in 'cd' command.
cd bzr213718
[edit the files with your favorite editor]
bzr commit -m 'Fix lp:213718 by adding pager support.'
bzr push lp:~daniel-vedder/bzr/pager

Then visit here:

https://code.launchpad.net/~daniel-vedder/bzr/pager/+register-merge

Fill out the form and submit.



More information about the bazaar mailing list