bzr-email fails if committer has non-ascii gecos

[Glenn Morris]

Vincent Ladeuil wrote:

> I'm not sure I follow as trying to dig the original traceback you sent I
> end up in 
>
>     def from_address(self):
>         """What address should I send from."""
>         result = self.config.get('post_commit_sender')
>         if result is None:
>             result = self.config.get('email')
>         return result
>
> So for that execution neither 'post_commit_sender' nor 'email' is
> defined but that doesn't match your description that the committer email
> is used (which in any case shouldn't require obtaining the gecos field
> !).

I don't know what self.config.get('email') is supposed to do.
I assumed it ended up calling config.py's default_email and hence
_auto_user_id, since that's where the error message came from.
Are you saying it should get the email from the revision information?

> Either bzr-email send emails from a fixed From in which case it always
> fail or succeed or it derives the From from the revisions info in which
> case it shouldn't need to query the local system (where the committer
> login may not exist or exists for someone else).

I verified by experiment that it sends emails using a From address
derived from my system account information. At least, that's what it
does when pushing to a central server. I did not check what it does if
everything is local to one machine.