Windows file locking with bzr 2.2.3

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/24/2011 4:12 PM, W. Trevor King wrote:
> On Thu, Feb 24, 2011 at 09:29:17PM +0000, Martin (gzlist) wrote:
>> If you're only ever passing the cwd for 'file_ids_from' Don't Do That.
>> This change makes your test script work for me:
> 
> Looking through the BE code, I also pass the repository root in for:
> 
> * bzrlib.builtins.cmd_revno         (as `location=self.repo`)
> * cmd = bzrlib.builtins.cmd_diff    (as `file_list=[self.repo]`)
> 
> Are these safe, or shall I also only set them for non-cwd
> repositories?
> 

Though should all be using a single location, which should be fine. In
fact, it is expected, since you are declaring where you want the command
to operate.

The only reason it wasn't working for 'cmd_add' was because you were
specifying the location 2 times. One as a read source, and one as a
write source.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1m2PkACgkQJdeBCYSNAAPQZACgxdyr+EACK6mgVOlnqGEDRws6
BDcAoIy/mjNWJ8TRGJZkdxQ/rAn2ruWn
=T7NJ
-----END PGP SIGNATURE-----