Subunit stream considers unexpected success as a success?

[Martin Pool]

On 29 September 2010 22:22, Gordon Tyler <gordon.tyler at gmail.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 9/29/2010 7:54 AM, Jonathan Lange wrote:
>> Testtools has code that maps addUnexpectedSuccess to addSuccess for
>> older TestResults.
>>
>> Subunit's TestProtocolClient (the bit that serializes test outcomes)
>> has this line:
>>       addUnexpectedSuccess = addSuccess
>>
>> Either of these could be causing your problem, but my money is on the second.
>>
>> I'm not sure the subunit protocol even has a way of encoding unexpected success.
>
> The simplest solution would be to map unexpected success to failure with
> a prefix message like "test succeeded unexpectedly". All the testing
> frameworks that I've seen so far treat an unexpected success as a failure.

+1, I think the code jml quotes is buggy.

-- 
Martin