Subunit stream considers unexpected success as a success?

[Gordon Tyler]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 9/29/2010 7:54 AM, Jonathan Lange wrote:
> Testtools has code that maps addUnexpectedSuccess to addSuccess for
> older TestResults.
> 
> Subunit's TestProtocolClient (the bit that serializes test outcomes)
> has this line:
>       addUnexpectedSuccess = addSuccess
> 
> Either of these could be causing your problem, but my money is on the second.
> 
> I'm not sure the subunit protocol even has a way of encoding unexpected success.

The simplest solution would be to map unexpected success to failure with
a prefix message like "test succeeded unexpectedly". All the testing
frameworks that I've seen so far treat an unexpected success as a failure.

Ciao,
Gordon
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJMoy99AAoJEIrPJfWinA2uJQQH/jY5Z7EEnuij6cMwkfT6DuZe
3113yMwB1DDhkibjKPTlpB/Dkl0lcr+2OjW3oKov03h/5McZs9HLhxlffKPWMnNd
aT5Zehwhd3VYCSzlyjpU3pSNN3hZCKPWs1g7L95P7Hhj+a4nvlQduTyM6vJt+Mik
9hMeFJXz4EmrujTaGVWSYBKy1X0mM0vAeFeMi0AUbLp+M1aectBl7tHKpM6uBWH3
QtREUTqSCK5dIJhDursZUEcaV1kYrsLUHvobLn1uTa44hFtm9eCEnVrimzm950Oq
JPm6AVIFbEE8ASbM0Wg3bQ+boNTkxyExAku1fe09tVkHUpAMdwmRLhZJJroy3Bc=
=ZswF
-----END PGP SIGNATURE-----