Installing 'update-copyright' on PQM

[Vincent Ladeuil]

>>>>> Martin Pool <mbp at canonical.com> writes:

    > On 24 June 2010 15:44, Martin Pool <mbp at canonical.com> wrote:
    >> As it happens an example of this just came up in Vincent's cleanup
    >> branch <https://code.edge.launchpad.net/~vila/bzr/cleanup/+merge/28306>:
    >> 
    >> On 24 June 2010 04:37, Vincent Ladeuil <v.ladeuil+lp at free.fr> wrote:
    >>> === modified file 'bzrlib/annotate.py'
    >>> --- bzrlib/annotate.py  2010-06-04 03:09:35 +0000
    >>> +++ bzrlib/annotate.py  2010-06-23 18:34:40 +0000
    >>> @@ -1,4 +1,4 @@
    >>> -# Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Canonical Ltd
    >>> +# Copyright (C) 2005-2010 Canonical Ltd
    >>>  #
    >>>  # This program is free software; you can redistribute it and/or modify
    >>>  # it under the terms of the GNU General Public License as published by
    >> 
    >> I had written some small amount of Python code for Bazaar in 2004, and
    >> other people had written things that merged into Bazaar.  I don't know
    >> off hand if any of that code still exists in annotate.py, but you
    >> probably don't know that either.  It is a bit icky that
    >> update_copyright (I presume) is changing this header even when Vincent
    >> is making no other overall changes to this file.

    > I should say that in practice, there probably isn't enough annotate
    > code from 2004 to be worth worrying about, and while I would prefer
    > Vincent merge without those changes, I wouldn't veto the patch.  But
    > it is a mark against using this code automatically.

Definitely something I should take into account. This strongly suggests
that update_copyright usage should be split:

- add *current* year only if a file is modified,

- have a mode where all files are checked and the copyright changes
  *proposed* so we can check each file individually.

I'm afraid there are already too much corner cases to hope for an
automated process there :-/

          Vincent