Installing 'update-copyright' on PQM

Martin Pool mbp at canonical.com
Thu Jun 24 06:47:12 BST 2010


On 24 June 2010 15:44, Martin Pool <mbp at canonical.com> wrote:
> As it happens an example of this just came up in Vincent's cleanup
> branch <https://code.edge.launchpad.net/~vila/bzr/cleanup/+merge/28306>:
>
> On 24 June 2010 04:37, Vincent Ladeuil <v.ladeuil+lp at free.fr> wrote:
>> === modified file 'bzrlib/annotate.py'
>> --- bzrlib/annotate.py  2010-06-04 03:09:35 +0000
>> +++ bzrlib/annotate.py  2010-06-23 18:34:40 +0000
>> @@ -1,4 +1,4 @@
>> -# Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Canonical Ltd
>> +# Copyright (C) 2005-2010 Canonical Ltd
>>  #
>>  # This program is free software; you can redistribute it and/or modify
>>  # it under the terms of the GNU General Public License as published by
>
> I had written some small amount of Python code for Bazaar in 2004, and
> other people had written things that merged into Bazaar.  I don't know
> off hand if any of that code still exists in annotate.py, but you
> probably don't know that either.  It is a bit icky that
> update_copyright (I presume) is changing this header even when Vincent
> is making no other overall changes to this file.

I should say that in practice, there probably isn't enough annotate
code from 2004 to be worth worrying about, and while I would prefer
Vincent merge without those changes, I wouldn't veto the patch.  But
it is a mark against using this code automatically.

-- 
Martin



More information about the bazaar mailing list