lock_* API change

[Jelmer Vernooij]

On Fri, 2010-05-14 at 19:26 +1200, Robert Collins wrote:
> On Fri, May 14, 2010 at 5:59 PM, Russel Winder <russel at russel.org.uk> wrote:
> > On Thu, 2010-05-13 at 13:44 +0200, Jelmer Vernooij wrote:
> >> On Wed, 2010-05-12 at 19:18 +1200, Robert Collins wrote:
> >> > Yesterday we landed a change to the lock_* API's which needs an action
> >> > taken by all implementors of lock_* methods. In particular,
> >> > bzr-svn/bzr-git/bzr-hg are likely to need an update.
> >> >
> >> > The change is pretty trivial - see the patch in trunk.
> >> Is this in preparation of the (eventual) removal of
> >> {Repository,Branch,WorkingTree}.unlock() ? What are your plans with the
> >> locking API ?
> >
> > A number of what I hope are interrelated and constructive, albeit
> > somewhat adversely critical, observations:
> >
> > 1.  It seems strange that a breaking change has been made to bzr.dev
> > that has caught plugin developers by surprise.
> 
> Its entirely normal for trunk bzr and trunk plugin bzr-FOO to be out
> of sync from time to time. We use this list to talk about things like
> this. I don't know if Jelmer was caught by surprise or not - the merge
> in question was up for a week or so - it wasn't rushed through in any
> sense.
I haven't been paying close attention to the merges into Bazaar
recently. This issue has been fixed in bzr-svn trunk yesterday, within
the same day that Rob mentioned it to me. The only way we can improve
this process is to have separate branches in which we prepare API
changes like this and then merge into all plugins and bzr.dev at once.
While that is possible it is also costly because it involves a fair
amount of coordination and other overhead.

Personally I work with two versions of Bazaar installed (a stable
version provided by my system and bzr.dev) so I can always fall back to
the stable version if anything comes up. Perhaps that's something you
might want to consider doing as well ?

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20100514/88e04e5c/attachment.pgp