reviews needed, apply within

Martin Pool mbp at canonical.com
Tue Apr 20 07:36:54 BST 2010


On 19 April 2010 16:45, Robert Collins <robertc at robertcollins.net> wrote:
> This didn't feel quite right to me, so I've gone and had a browse; I think
> that essentially we had a number that are waiting on the submitter, but are
> set needs-review (waiting on reviewers); so I've toggled them to
> work-in-progress.

When there's a proposal by a non-core person that needs more work, I
don't think we should just put it back in their lap.  (If it's a core
person it's reasonable to expect that they will either finish it off,
or ask for help, or make a reasonable decision that it's not worth
pursuing, but less frequent contributors may get stuck.)

To me the patch pilot experiment showed that biasing towards being a
bit more zealous in finishing these off is very worthwhile.  One might
think that it's not a good use of core developer time to work on bugs
that aren't directly a high priority, but I think it does pay off
through making contribution more fun and avoiding stalling.

In <https://code.edge.launchpad.net/~songofacandy/bzr/fix-523746-dev/+merge/20537>
Vincent gave Naoki a bit of a clue what to do next, but after no
progress for two weeks it's not a safe assumption that Naoki is just
going to come back and do it.  I would like core people to at least
offer to write the tests for him.  It may be he just needs a bit of
help but if writing the tests is hard, and sometimes it is, we should
do it so the original change lands.  Even if you don't think the
particular bug is important, helping people enjoy making changes is
important.

So I said the queue is getting long but what I really meant is that I
would like some core contributors to help finish off languishing
patches.

-- 
Martin <http://launchpad.net/~mbp/>



More information about the bazaar mailing list