PQM getting tweaked

[Robert Collins]

On Tue, Apr 20, 2010 at 12:46 PM, Martin Pool <mbp at canonical.com> wrote:

> On 20 April 2010 12:30, Robert Collins <robertc at robertcollins.net> wrote:
> >> So the question is, which things are being sent through this path?
> >
> > Things which someone uses my branch of hydrazine to submit. I'm
> submitting
> > things using that branch because its easy.
>
> oh ok, so this changes 's' from 'send a mail' to 'queue for automatic
> merge'.  It seems like we could have one branch that does both...
>

It looked rather ugly when I was coding the changes. Yes, it is in principle
possible.


> >> What is supposed to happen if submission fails?
> >
> > I'm not sure what you mean here. If you mean 'if the s command in
> hydrazine
> > blows up' - well, then the proposal will be unaltered, you can debug
> whats
> > going on / send via email /  file a bug on the cause of the problem.
> >
> > If you mean 'what if PQM doesn't notice the queued branch', - have a look
> at
> > the web UI for PQM, and if your branch hasn't turned up there after 4-5
> > minutes (launchpadlib is slow), then send via email (and report the
> issue).
>
> I meant 'what if make check fails' - where does the failure message go?
>

In theory: attached to the merge proposal. In practice - iz a bug in the
handler that does that for LP, but its fixed now, I hope.


> >>> spiv: (It got Queued, so it went invisible on +activereviews where I
> expect to see my not-quite-landed work, plus the new setup doesn't seem to
> be able to send failures yet, it just keeps trying it over and over without
> any feedbck)
>
> this seems poor...
>

I filed a bug for this last week
https://bugs.edge.launchpad.net/launchpad-code/+bug/561157

-Rob
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20100420/77fcdee9/attachment.htm