<br><br><div class="gmail_quote">On Tue, Apr 20, 2010 at 12:46 PM, Martin Pool <span dir="ltr"><<a href="mailto:mbp@canonical.com">mbp@canonical.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="im">On 20 April 2010 12:30, Robert Collins <<a href="mailto:robertc@robertcollins.net">robertc@robertcollins.net</a>> wrote:<br> >> So the question is, which things are being sent through this path?<br> ><br> > Things which someone uses my branch of hydrazine to submit. I'm submitting<br> > things using that branch because its easy.<br> <br> </div>oh ok, so this changes 's' from 'send a mail' to 'queue for automatic<br> merge'. It seems like we could have one branch that does both...<br><div class="im"></div></blockquote><div><br>It looked rather ugly when I was coding the changes. Yes, it is in principle possible.<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="im"> >> What is supposed to happen if submission fails?<br> ><br> > I'm not sure what you mean here. If you mean 'if the s command in hydrazine<br> > blows up' - well, then the proposal will be unaltered, you can debug whats<br> > going on / send via email / file a bug on the cause of the problem.<br> ><br> > If you mean 'what if PQM doesn't notice the queued branch', - have a look at<br> > the web UI for PQM, and if your branch hasn't turned up there after 4-5<br> > minutes (launchpadlib is slow), then send via email (and report the issue).<br> <br> </div>I meant 'what if make check fails' - where does the failure message go?<br></blockquote><div><br>In theory: attached to the merge proposal. In practice - iz a bug in the handler that does that for LP, but its fixed now, I hope.<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> >>> spiv: (It got Queued, so it went invisible on +activereviews where I expect to see my not-quite-landed work, plus the new setup doesn't seem to be able to send failures yet, it just keeps trying it over and over without any feedbck)<br> <br> this seems poor...<br></blockquote><div><br>I filed a bug for this last week <a href="https://bugs.edge.launchpad.net/launchpad-code/+bug/561157">https://bugs.edge.launchpad.net/launchpad-code/+bug/561157</a><br><br>-Rob <br> </div></div><br>