[RFC] "bzr cat-revision"

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij wrote:
> Hi,
> 
> bzr cat-revision is the only remaining user of
> Repository.get_revision_xml(), a method I would like to remove.
> 
> There are a couple of reasons I'd like to get rid of it:
> 
>  * while its name suggests it will return XML it actually returns
> bencode for 2a repositories
>  * it is yet another method on Repository
>  * there is no meaningful way to implement it for e.g. svn repositories
>  * it doesn't actually return the original raw revision data but rather
> parses that and uses the same serializer to re-generate it
> 
> "bzr cat-revision" seems mostly a debugging command. Would it make sense
> to just have it call out to Repository.revisions.get_record_stream() and
> print the revision data it finds there for the specified revision? For
> repositories that don't have a meaningful .revisions it could print an
> error. 
> 
> Cheers,
> 
> Jelmer

It is a hidden command, right? I wouldn't mind if it was just removed.
Martin removed a bunch of Weave related commands in 2.2 as well.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkt2KKUACgkQJdeBCYSNAAOyZwCdHOx8C3q60xxVH72hqqJIU/kz
YdoAnRxLoE3iOOxLcd9UdT9HwoaUM570
=/hfJ
-----END PGP SIGNATURE-----