[RFC] Ask for confirmation if the commit message is a file name

[John Szakmeister]

On Wed, Nov 11, 2009 at 9:20 PM, Forest Bond <forest at alittletooquiet.net> wrote:
> Hi,
>
> On Thu, Nov 12, 2009 at 12:29:32AM +0100, Gioele Barabucci wrote:
>> sometimes I mistakenly type "commit -m file1 file2", i.e. I forget to add a
>> commit message and bzr uses "file1" as the commit message. With the attached
>> tiny patch, bzr will ask the user for a confirmation in cases like that.
>
> I would prefer if this simply printed a warning and carried on with the commit
> anyway.  It's not hard to uncommit, and requiring --force or interactive
> confirmation makes the UI behavior vary based on the presence of a file, which
> seems unpredictable to me.

You can't really uncommit if you're operating against a foreign repo,
or in checkout mode.  I'd prefer that you had to force it if the
message is the name of a file.

-John