[RFC] Ask for confirmation if the commit message is a file name

Forest Bond forest at alittletooquiet.net
Thu Nov 12 02:20:12 GMT 2009


Hi,

On Thu, Nov 12, 2009 at 12:29:32AM +0100, Gioele Barabucci wrote:
> sometimes I mistakenly type "commit -m file1 file2", i.e. I forget to add a 
> commit message and bzr uses "file1" as the commit message. With the attached 
> tiny patch, bzr will ask the user for a confirmation in cases like that.

I would prefer if this simply printed a warning and carried on with the commit
anyway.  It's not hard to uncommit, and requiring --force or interactive
confirmation makes the UI behavior vary based on the presence of a file, which
seems unpredictable to me.

-Forest
-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20091111/c715f742/attachment-0001.pgp 


More information about the bazaar mailing list