api_minimum_version not been bumped.

Martin Pool mbp at canonical.com
Mon Sep 28 19:48:14 BST 2009


2009/9/28 Gary van der Merwe <garyvdm at gmail.com>:
> On Mon, Sep 28, 2009 at 6:05 PM, John Arbash Meinel
> <john at arbash-meinel.com> wrote:
>> Why do you need to use CLIUIFactory before it was deprecated? I'm mostly
>> asking to help shed light on how this sort of thing needs to be handled.
>>
>> At least, from what I remember from Martin, it was duplicated with other
>> code. Though perhaps not before deprecation?
>>
>> Getting feedback here is something that I think will help guide future
>> decisions about deprecations, etc.
>
> Looking at the specifics, before 1.18, TextUIFactory did not have
> make_progress_view. Previously, we provided CLIUIFactory with a custom
> progress_view in some other way. When that change first occured, I
> tried to port the code from the CLIUIFactory, to the new TextUIFactory
> for backward compatibility. After reviewing that code now, I realised
> a much simpler way to maintain the backward compatibility
> (_make_progress_view = make_progress_view).

That's good.

I'm curious too whether the minimum_api_version has actually been
useful for you in general, as opposed to just checking the actual
bzrlib version.
-- 
Martin <http://launchpad.net/~mbp/>



More information about the bazaar mailing list