[RFD] Merge proposals and code reviews too private

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthew D. Fuller wrote:
> On Thu, Aug 20, 2009 at 02:07:22AM -0400 I heard the voice of
> Aaron Bentley, and lo! it spake thus:
>> If the Bazaar project wants to use a tool that wasn't designed
>> specifically for it, the project will have to adapt.
> 
> Sure.  I don't claim our existing flow is perfect, certainly.  But it
> _hasn't_ adapted; we're using Reviews just like BB.  And, AFAICT, it
> wasn't ever _decided_ that it was fine; the question was never
> actually raised.  It should be.

It was proposed as an experiment.  Martin's declared the experiment a
success.  There have certainly been opportunities to discuss it before now.

>> I don't see how asking people to submit their code to a code review
>> system is inconsistent with code review being separate from the
>> general discussion list.
> 
> The point is we've been asking people to submit their code to a code
> review system long before the point where their message is "Please
> consider this for merging", way back at the point where their message
> is "Hey, I made this $THING, let's talk about whether we want it
> {,like this}".

I don't think that's actually what we actually encouraged.  In fact, I
frequently rejected stuff that wasn't in a mergeable state with the
message "Not intended for merging" back in the BB days.  Such things are
clutter.  If I can't merge it, it doesn't belong in our list of things
to consider merging.

In any case, I don't think we want such things tracked in the code
review system.  There are enough legitimate code reviews without adding
RFCs.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqM7p4ACgkQ0F+nu1YWqI0pUQCgh6YRF2zDn/mrR+ADvd/kNfff
jvgAn1dEYnPm7E1XT2UL3UHlM0moDFHS
=7W3A
-----END PGP SIGNATURE-----