[MERGE] better support of unicode paths on Windows

Alexander Belchenko bialix at ukr.net
Tue Jul 7 10:09:31 BST 2009


Martin (gzlist) пишет:
> 2009/7/3 Alexander Belchenko <bialix at ukr.net>:
>> Bzr has one latent bug related to create new .bzr directory inside unicode
>> directory. The problem occurs when unicode path cannot be encoded in current
>> user encoding, as pointed by INADA Naoki, see
>> https://bugs.launchpad.net/tortoisebzr/+bug/335362/comments/41
> 
> Patch (with your later fix) looks good to me.
> 
> Makes me realise I introduced a regression in this area.

Yes, you are.

> I was under
> the impression that CreateFile was one of the pywin32 functions that
> varied given a str or unicode argument, but actually it's the A
> version and there's a seperate W version. It's an easy fix if I don't
> finish my rearrange for the 1.17 window though.

I wrote required fix, see:
https://code.launchpad.net/~bialix/bzr/lock-unicode-win32/+merge/8297

It should be merged to 1.17 to avoid regression.





More information about the bazaar mailing list