RFC: iter_changes with specific_files, status and commit

[Robert Collins]

So, one kindof-principle about status is that it tells you what commit
will do. This isn't _strict_ and it falls down with specific files.

I've been looking at adding automatic inclusion of parents to
iter_changes to ensure that commit generates valid inventory deltas.
Currently given a change like:

A b
R a->b/c

doing 'commit b/c' will commit both the new file b and the rename of a
to c, because b is above an added-or-reparented entry.

However, doing 'st b/c' lists *only* the rename.

Adding automatic inclusion of parents would make 'st b/c' show both
changes.

Below the UI level, this is very simple: expose the yield_parents
parameter of inventory.iter_entries_by_dir, and add some small set
tracking logic to dirstate's iter_changes. PreviewTree may need
something different but I imagine it will be fairly straight forward.

I'm seeking specific feedback:
 - does this sound reasonable at the UI layer.
 - can anyone see some unexpected issues?

-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090626/214c2af2/attachment.pgp