[MERGE] Some revision-info fixups
Matthew D. Fuller
fullermd at over-yonder.net
Fri Jun 5 21:48:27 BST 2009
On Fri, Jun 05, 2009 at 08:51:02AM -0500 I heard the voice of
John Arbash Meinel, and lo! it spake thus:
>
> If you really prefer the aligned form, then I think we can go with that.
Well, I was just going from the pre-existing
revno = '%4d' % (b.revision_id_to_revno(revision_id))
which sorta half-assed did the same thing, it just misaligned when you
got over 10k revisions or got into dotted numbers. e.g., bzr.dev on
bzr.dev:
% bzr revision-info 1 10 100 1000 4401.1.4
1 mbp at sourcefrog.net-20050309040815-13242001617e4a06
10 mbp at sourcefrog.net-20050309064900-74935ffb7350b24b
100 mbp at sourcefrog.net-20050326134153-3fd9d2c0ee5a06ce
1000 mbp at sourcefrog.net-20050729134025-9abbcae0d0faf25f
4401.1.4 john at arbash-meinel.com-20090604021546-n2pgaxdkilitdpq5
I just made it work consistently. I don't have a particularly strong
feeling left-vs-right, though I think I like right better; on long
lists it makes it easier to match up.
> meh... (honestly, I wonder how often people ever give more than 1
> revision to this command anyway...)
Going from available evidence, every time they're doing unrelated
changed to revision-info and revno and notice a little mess in r-i
that could be cleaned up at the same time 8-}
> I'm probably going for the right-aligned, and I approve on concept.
> If you like my resubmission for your other patch, then the two will
> need to be resolved to work together.
At a glance (I didn't look in depth), it seems like your changes to
the other patch may have done most of this except the alignment stuff.
--
Matthew Fuller (MF4839) | fullermd at over-yonder.net
Systems/Network Administrator | http://www.over-yonder.net/~fullermd/
On the Internet, nobody can hear you scream.
More information about the bazaar
mailing list