[MERGE] Some revision-info fixups

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthew D. Fuller wrote:
> This fixes up revision-info so that it
> 
> (1) Uses Branch.revision_id_to_dotted_revno() instead of
>     reimplementing it manually,
> 
>   (1.5) and does so locked so that it doesn't get revuilt every time
>         it needs checked if you're asking about multiple revs, so it's
>         much faster in those cases,
> 
> (2) Aligns the output based on what there actually is, rather than
>     hardcoding a guess at the length of a revno, and
> 
> (3) Shows something more sensible than a blowup and traceback when
>     given a revision it can't find in the {branch,repo}.
> 
> 
> 

I think I did everything except for the alignment change, as I'm not
100% sure what I would want to see there.

If you really prefer the aligned form, then I think we can go with that.
Though I'm thinking that left aligned may be better. So instead of:

    1  rev-1
1.1.1  rev-2

we would have

1      rev-1
1.1.1  rev-2

I don't have a strong feeling either way, though. I guess *numbers*
should normally be right-aligned, but dotted number sort of confuse it.
I don't think we want:

  10     rev-old
5000     rev-new
  10.1.1 rev-dotted

so then you have:

    10 rev-old
  5000 rev-new
10.1.1 rev-dotted

vs

10     rev-old
5000   rev-new
10.1.1 rev-dotted

meh... (honestly, I wonder how often people ever give more than 1
revision to this command anyway...)


BB:tweak

I'm probably going for the right-aligned, and I approve on concept. If
you like my resubmission for your other patch, then the two will need to
be resolved to work together.

John
=:->


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkopIsYACgkQJdeBCYSNAAM2MwCfU0EjzyiInPrzfJEah3OYL4d7
qfcAn2b7gwx6HbZG5bj3UAoLVQ2zqyPd
=e4N3
-----END PGP SIGNATURE-----