Failure to fetch to old format via Smart Server

[Robert Collins]

On Mon, 2009-06-01 at 12:48 -0500, John Arbash Meinel wrote:
> 
> (sorry about the ugly formatting)
> 
> Anyway, it would seem that Smart Server + fetch + Knit formats is
> broken, and we never knew it, because we never had a per-format test
> of
> fetching and the smart server.

Pushing is, but pulling shouldn't be. It looks relatively easy to fix to
- just move the reconcile check down into the sink.

> I don't feel like fixing this for my current patch, so I'll probably
> just blacklist specific versions.
> 
> I'll note that it looks like an even simpler failing test would be:
> 
> 
> def test_can_ensure_real_locked_repo(self):
>   trans = self.make_smart_server('repo')
>   self.make_repository('repo')
>   # Open repo via smart server
>   repo = repository.Repository.open(trans.base)
>   repo.lock_write()
>   self.addCleanup(repo.unlock)
>   repo._ensure_real() # Boom

That would test the specific aspect, but thats a symptom of the format,
and not fixable.

-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090602/04e2cded/attachment.pgp