InterRepo versus StreamSource

John Arbash Meinel john at arbash-meinel.com
Mon Jun 1 18:55:01 BST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Overall, I like the way the new StreamSource and StreamSink code works.
I'm working on an optimized StreamSource for KnitPack => KnitPack that
doesn't have to deal with format conversions, etc. In doing so, I would
remove the InterPackRepo optimizer.

Which revealed something to me. Namely, now that we allow a different
mechanism for determining inter-object fetching, shouldn't we really
have that as part of 'interrepository_implementations' (or more
appropriately per_interrepository) ?

I've also been finding *lots* of failures with various formats +
SmartServer, which says that we are missing some real test coverage
anyway. (Namely, I don't think we have any tests that ensure that every
format works for basic operations with a source/target of a
RemoteRepository, since every time I add a tests like that, I find
failures.)

Anyway, for now, all of my special cased StreamSource work on exactly
self._format == to_format, so testing them via 'per_repository' works
just fine. However, it did seem like those tests should exist in the
'interrepository' style tests....

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkokFfUACgkQJdeBCYSNAAOk4gCfQyYCRUCLFkPEYufp9U57zz84
2u4AoM1L92nod2wtCV1Czi0WZgMy0d9E
=B6tJ
-----END PGP SIGNATURE-----



More information about the bazaar mailing list