BEncode Pyrex

Martin Pool mbp at canonical.com
Tue May 26 09:55:22 BST 2009


2009/5/26 Jelmer Vernooij <jelmer at vernstok.nl>:
> This is Alexanders' Pyrex patch, merged into current bzr.dev. With this
> patch and the BEncode revision serializer patch I see about twice the
> performance as I get with the XML serializer.

Ooh, nice.

>
> I'm not sure about the patch itself entirely (so no [MERGE]), especially
> the fact that it moves the core bencode to "bzrlib.bencode" while
> leaving the existing python implementation in bzrlib.util. This makes it
> easy for people to accidently import the python version while they want
> the Pyrex one, if possible. Perhaps we should just move bencode to
> bzrlib.bencode, deprecate the name bzrlib.util.bencode and move the
> existing python implementation to bzrlib._bencode_py?

OK with me.
-- 
Martin <http://launchpad.net/~mbp/>



More information about the bazaar mailing list