[RFC] upgrade ordering & UI

[Jelmer Vernooij]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Ian,

Ian Clatworthy wrote:
> On the UI front, I have some things I'd like feedback on:
> 
> 1. I'm planning to add a --clean option that will delete backup.bzr
>    for things that successfully upgraded. I think explicit is good here.
>    Does everyone agree? Right now, I do all the clean-up after all the
>    upgrades. Would progressive clean-up be better? I guess it is if
>    you interrupt things but it feels slightly less safe?
+1

I would prefer progressive cleanup, as that means I can upgrade my
mirrors of svn branches without running out of disk space. It also means
that if you Ctrl-C halfway through you don't end up with backup.bzr
directories where you don't know if the upgrade was successful or not
(so you can remove them).

> 2. Robert has asked for an upgrade to dev6rr to be followed by a pack.
>    Should that be implicit or an option? It seems to me that we ought to
>    clean out obsolete_packs iff we pack as part of upgrade and --clean
>    is given as an option. All agree?
I think this should be implicit with perhaps an option to prevent it (is
there any good reason to not pack other then saving a few CPU cycles?).
Not sure about cleaning out obsolete_packs.

> 3. I've suggested a --find option to search for repos/branches/checkouts
>    to upgrade. I think that will be good because it allows upgrade to
>    smartly order things, e.g. stacked before unstacked. Another option
>    though is for upgrade to take a list of directories to upgrade. That
>    seems more flexible but it then requires a separate command to find
>    those directories and optionally intelligently order them. Any
>    preference on direction here? (It will be a follow-up patch
>    regardless.)
Either seems good to me. Specifying a list of directories seems slightly
more "natural" to the unix user in me perhaps. If I was new to bzr and
hadn't read the upgrade help, it would be the first thing I'd try.

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iJwEAQECAAYFAkoMEB4ACgkQDLQl4QYPZuVPrgP9Ecu7Ote+ChcfD6KgPjzxTwLI
5c6VR874bklim84Z25GyTGzNPs7J3oVJ9SoaowNL0Is98NvSGd7L81/piMRKA9l9
7Va6tPys7QTDDMinE4/bwz02KamO6oMpzN3ceg/6iaoWy2CKYPZHjBTPbf11gHR7
0TgczNROOPRd2HJouNs=
=EYBG
-----END PGP SIGNATURE-----