[MERGE] Using unicode Windows API to obtain command-line arguments.(#375934)

John Arbash Meinel john at arbash-meinel.com
Wed May 13 23:03:33 BST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
...

> It changes the definition of the argv parameter in main(). Now, I don't
> think that main() is really the recommended api (that would be run_bzr).
> But I'm tempted to instead do:

...

> So I'll leave the choice up to you. But I would like the code here to
> ensure that argv is a list of unicode strings when it is done.

...

I should mention that however main() gets changed, we should probably
have some information in NEWS about the difference. Something like:

  Not passing arguments to ``bzrlib.commands.main()`` will now grab the
  arguments from ``osutils.get_unicode_argv()`` which has proper support
  for unicode arguments on windows.


And if you change compatibility, you should add:

  Further, the supplied arguments are now required to be unicode
strings, rather than user_encoded strings.

Or something along those lines.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkoLQ7UACgkQJdeBCYSNAAND3QCgwkQ5uqgXH8KEPNmkug/BsJH8
AAkAni+ExwMzg9JqHdo2aFJmucMn9Na3
=c9L/
-----END PGP SIGNATURE-----



More information about the bazaar mailing list