API for check

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> So, to get check reporting all errors, we need to stop raising
> BzrCheckError in bzr check; rather we need to accumulate errors and
> report them.
> 
> I'm thinking of just adding a 'was_ok' attribute to the Check*Result
> objects; programmers can then use that for flow control if desired.
> 
> Thoughts?
> 
> -Rob
> 

'was_ok' is ok, but seems like just a boolean. Why not 'errors' as a list?

I like the idea of accumulating issues, though I'm slightly worried
about cascading issues. (Like when compiling C, a missing } can cause
many pages of 'errors', when there is only a simple syntax error.)

I don't think we'd have a lot of chained issues, though, so I think
accumulating would be better than not.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkoELy8ACgkQJdeBCYSNAANnowCghcICmJ60PO0NcwPm5jzQraTS
AoAAn2qTE/v6PoowbqmEoXRJfZyoodAI
=PyB3
-----END PGP SIGNATURE-----