[MERGE] Patch: smtp_connection.py

[Vincent Ladeuil]

>>>>> "Amit" == Amit Saha <amitsaha.in at gmail.com> writes:

    Amit> Hello,
    Amit> Feature added:

    Amit> When 'smtplib' is used for commit emails, the 'smtp_connection.py'
    Amit> reads the SMTP configuration from the bazaar configuration file. This
    Amit> basically forces the user to store the email password in
    Amit> 'smtp_password' in plain text. This might be undesirable for many
    Amit> users, like me. The current patch to the code removes that necessity
    Amit> and if the smtp_password field is left blank, then it automatically
    Amit> prompts for the password after the commit is done. The password is
    Amit> masked.

If you don't specify stmp_username/smtp_password in the
configuration file, smtp_connection._authenticate() will try to
find them in authentication.conf.

If you don't want to specify your password there *but* specify
your user name, bzr will prompt you for the password.

If *that* doesn't work, file a bug and *then* send us a patch
that fixes it :)

   Vincent